Skip to content

Conversation

oxinabox
Copy link
Contributor

@oxinabox oxinabox commented Dec 13, 2024

Copy link
Member

@cdiener cdiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The linter was complaining about a docstring.

@cdiener
Copy link
Member

cdiener commented Jan 7, 2025

There was another small issue with the logic in Reaction.build_reaction_from_string. Let me know if the changes are fine with you.

@oxinabox
Copy link
Contributor Author

oxinabox commented Jan 7, 2025

lgtm

@cdiener cdiener merged commit e5fc6ed into opencobra:devel Jan 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] When a new metabolite is created during build_reaction_from_string it's compartment is not set
2 participants